[POLL] [POLICY] New/Updated NTstation Policy Proposal

[Neerti]

The draft is here: https://docs.google.com/document/d/19V6 ... Lzksk/edit

The current policies for the codebase is horribly out of date, as it was written in Polymorph era, which assumed everyone had commit access.

This is a more up to date version. Miggles approved of it and so I'd like to put it up for a two week vote, as stated in the draft.

Please vote, and also give feedback on what you think should be changed.
The vote has ended with 100% for yes. (abstain is obviously not counted)

Now it's time for maintainers to vote on it.
Miggles: Approve
Remie: Approve
It's now live.

[paprika]

PRs need to have [MAP] in the title if there are map changes and [WIP] if they are WIP -before- the name of the PR.

[Jordie0608]

So out of interest; The whole "Anyone's PR will be merged and everyone gets commit access" was something I respected about NTstation, what happened to change that?

[paprika]

Conflicts and laziness. Same principle now except now we have maintainers so those people can get coder flags in game basically.

[miggles]

So out of interest; The whole "Anyone's PR will be merged and everyone gets commit access" was something I respected about NTstation, what happened to change that?

this has not been the case with NT, literally ever
it was what polymorph proposed for the codebase before (she?) left, and it was a horrible idea that would lead to nothing but rampant instability and horrible features
the idea was never actually exercised before poly left and dannos and i took over
i wrote up a new set of rules on the old forums and i was rather sure i ported them here too, but it looks like i didnt, and since neerti was working on this ruleset i decided i would hold off on that since it would be replaced soon enough anyway

[Jordie0608]

Well that shows the amount of attention I pay to NT's policies then.

[Neerti]

I'd like this to get more attention, as it's very important for the codebase.

[paprika]

I don't think anyone really gives a shit since most of the contributors already know not to be a huge retard and it's mostly policy for new people. As long as the basics are there I'm sure there's literally no problem with it.

I love the What is... section in particular.

Here's a suggestion:

Artyom
Is:
A server running NT station code hosted by scaredofshadows for the /tg/station community.
Is not:
Run by the same people that run NT Station.

Changes in bold.

[Neerti]

Changes applied. Thank you.

[Neerti]

Tomarrow, when the poll closes, all the maintainers need to come to a vote and pass or reject the new policy.

[danno]

pass

[danno]

also i quit

[miggles]

not surprised

[Neerti]

I've edited the document to remove Danno's name from maintainers due to him quitting.

[Neerti]

I'm told by Remie he already voted yes. I would've perferred a meeting between all the maintainers but one's on vacation and the other quit so... ¯\_(ツ)_/¯

[paprika]

Fuck it man this isn't a case of you introducing WILDLY NEW POLICIES, it's mostly the same old shit with warranted updates to completely outdated shit. If we need to make changes to this down the road we will, but this looks perfectly acceptable and you don't have to fuss over trying to get everyone to have a big meeting about it or anything.

[Neerti]

This is now on the policy page on the gitwiki. Sadly git sucks at formatting but at least it's law now.

Yay.