Maps over 255x255 tiles crash?

[paprika]

Can someone point me in the right direction to find the code causing servers to crash if maps are larger than 255 tiles?

I've tried to byond detective my way into finding it in ss13 code but I can't seem to. I'm sure it's multiple things but I'm having a hard time finding it.

[onleavedontatme]

The TGM map format doesn't work with bigger maps.

[paprika]

The game shouldn't be crashing with non-TGM maps being loaded though, where is that happening? Can't you just a) increase the dimensions of TGM or b) load the maps using a legacy system?

Please don't tell me this wasn't considered.

[onleavedontatme]

https://github.com/tgstation/tgstation/pull/16026

You'd have to ask dunc who removed asteroid for longer working or

https://github.com/tgstation/tgstation/pull/17015

corruptcomputer who got asteroid working again by shrinking it

[paprika]

Oh god, those horrible words, "BYOND BUG"

I'll look into this in the future if it's ever fixed, though I'm sure by then you'll have a huge lavaland map eh? Thanks for looking around kor.

[Scott]

I don't know about the cause being 255x255 map size, but compilation fails (read: crashes DM) with the original Asteroid Station in TGM format. It's not about TGM not supporting big maps, it's about DM runtiming due to a memory handling error triggered by the TGM format.

It's a byond bug that is not being fixed any time soon, it was already reported and the report is gathering dust and cobwebs. Go bump it.

[oranges]

I'm pretty sure the max z level size being 255x255 is something else, maybe ask vg as they're running bigger maps now, so they might have insights on the limitations they hit.

[Remie Richards]

oranges it only triggers for TGM maps (for us atleast), because they bloat the size of the file (due to spacing things out per line to help git along with merging conflicts) and DM was just apparently never built to handle map files that are that big.

/vg/'s maps work over 255x255 because they don't use TGM.

[oranges]

Well the last I heard it wasn't map size causing the compile crash but just asteroid for some reason.

[MisterPerson]

It is map size, it's just only asteroid winds up being big enough in TGM.

[Remie Richards]

asteroid by default is 300x300 (or some numbers around that, but definitely our BIGGEST map) so having a bigger starting size, PLUS TGM is what triggered it here.
that's all that's special about Asteroid in terms of the crash, it's bigger before you apply TGM and it only gets BIGGER after you do, enough to reach this crash every (almost?) time.

[paprika]

Why does the filesize of a file get larger the more lines it has when it's essentially the same amount of information anyway, what a meme

[Bawhoppennn]

MSO made a Byond bug report looking for answers, maybe you could spam Lummox to help your quest

http://www.byond.com/forum/?post=2044362

[paprika]

I did, I used my two year subscriber influence to put it on his to-do list, soon we will have 1000x1000 lavastation.

[Jordie0608]

Why does the filesize of a file get larger the more lines it has when it's essentially the same amount of information anyway, what a meme

More lines means more metadata like line break characters.

[paprika]

thanks for coding 101 i'm retarded