Page 1 of 1

[PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 5:37 am
by ABearInTheWoods
So i'm changing up how starlight works.
https://github.com/tgstation/-tg-station/pull/12748
Gif showing old, new 1, and new 2.
Image

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 5:49 am
by Amelius
Old. Also if these new new changes go through, shadowlings definitely need some light tolerance or even maintenance will be a deathtrap.

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 6:15 am
by invisty
Great addition to gameplay. Honestly, this is a bit overdue.

I prefer the one with the dim light.

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 7:05 am
by Saegrimr
Im gonna guess the really dim one is New 2 since they aren't labeled, and vote for that.

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 7:33 am
by callanrockslol
I like new 1

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 9:31 am
by Miauw
dimmest one is cool.

does this mean that computer light is also going to be made dimmer?

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 1:13 pm
by Cheimon
Love it, especially new 1. Makes windows to space seem practical instead of just being potentially deadly decoration.

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 1:27 pm
by Stickymayhem
Dimmest is the best. Old starlight is so over the top and really doesn't make darkness threatening

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 1:35 pm
by Ricotez
it's kinda unrealistic, the stars are so far away they can't really visibly illuminate anything. if you're going with something like this then the dimmest one is probably best.

the local sun on the other hand should light up the station, unless it perpetually stays in the shadow side of the gas giant it orbits or something

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 3:07 pm
by Gun Hog
The station orbits a planet close enough to the system's star to where it can collect enough light to power all of its systems. Starlight in that case would realistically provide enough light (and radiation) for any exposed areas within the station. That being said, gameplay is more important here, so the dimmest version is best for Shadowlings.

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 3:10 pm
by CPTANT
There is already a sun tracking mechanism for the solars right?

Wouldn't it be awesome if the side exposed to the sun got lit and the rest stayed dark?

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 3:10 pm
by Steelpoint
Version 2 seems more moodier.

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 4:08 pm
by asskek
Dimmest is most realistic

But if we're going with lore and we are near a sun, the sort-of bright but not brightest option

edit: which considering we have solars seems to make sense

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 4:59 pm
by Davidchan
asskek wrote:Dimmest is most realistic

But if we're going with lore and we are near a sun, the sort-of bright but not brightest option

edit: which considering we have solars seems to make sense
If its bright enough to burn Shadowlings/Shadowpeople it should be bright enough to light up areas close to windows better than a PDA light.

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 5:07 pm
by Scott
The station runs on solar power, dim light from the exterior makes no sense. It has to be bright.

Re: [PR][poll]Starlight changes

Posted: Sat Oct 31, 2015 5:34 pm
by ABearInTheWoods
I just checked... almost all of the starlight illuminated maintenance areas in the dimmest version are not bright enough to hurt shadowlings (but they are bright enough to hurt normal shadow people). Most of them will however be bright enough to prevent healing.

Shadow lings brightness values:
below 20%: heal
20 to 40: no heal, no damage
above 40: damage.

Sadly neither damage nor healing scale with the brightness level (like they should).

Only the tiles that are at least two tiles in of single tile wide paths surrounded on both sides with windows to space reach above 40%. Everything else hovers between 17% and 34% (of maintenance areas near a window to space).

I also went and fixed some areas of space that were stuck on 100% brightness but had tiles on them that were near the station.
Image
Image

Re: [PR][poll]Starlight changes

Posted: Sun Nov 01, 2015 3:34 pm
by Oldman Robustin
Dimmest