Page 1 of 1

rip toxins

Posted: Sun Aug 01, 2021 9:08 pm
by Rohen_Tahir
toxins is getting removed this week

Re: rip toxins

Posted: Sun Aug 01, 2021 9:27 pm
by Jonathan Gupta
Rohen_Tahir wrote:toxins is getting removed this week
whats next engineering?

Re: rip toxins

Posted: Sun Aug 01, 2021 10:58 pm
by Nabski
what?

Re: rip toxins

Posted: Sun Aug 01, 2021 11:02 pm
by sinfulbliss
Lies and falsehood.

Re: rip toxins

Posted: Sun Aug 01, 2021 11:28 pm
by Rohen_Tahir
sinfulbliss wrote:Lies and falsehood.
It's true. The removal PR was opened on Sunday.

Re: rip toxins

Posted: Mon Aug 02, 2021 2:04 am
by Omega_DarkPotato
https://github.com/tgstation/tgstation/pull/60619
imo
ordnance is infinitely cooler and far more accurate

Re: rip toxins

Posted: Mon Aug 02, 2021 2:12 am
by Armhulen
This mostly has some serious code improvement behind it, the front end is whatever

Re: rip toxins

Posted: Mon Aug 02, 2021 6:24 am
by sinfulbliss
Cuban Pete is rolling in his grave. Toxins sounds so much better than Ordnance... And plasma causes toxin damage anyway so it's not, like, terribly inaccurate.

What if you renamed it to "T0xinz" instead? That'd fix the pathing issue right? Or like "T.oxins"? I dunno man seems weird to change the whole name that's been that way for years because of how it shows up in the cooder programs.

Re: rip toxins

Posted: Mon Aug 02, 2021 6:26 am
by EOBGames
What will those crazy coders do next

Re: rip toxins

Posted: Mon Aug 02, 2021 6:51 am
by TheFinalPotato
sinfulbliss wrote:Cuban Pete is rolling in his grave. Toxins sounds so much better than Ordnance... And plasma causes toxin damage anyway so it's not, like, terribly inaccurate.

What if you renamed it to "T0xinz" instead? That'd fix the pathing issue right? Or like "T.oxins"? I dunno man seems weird to change the whole name that's been that way for years because of how it shows up in the cooder programs.
what?

Re: rip toxins

Posted: Mon Aug 02, 2021 7:11 am
by sinfulbliss
TheFinalPotato wrote:
sinfulbliss wrote:Cuban Pete is rolling in his grave. Toxins sounds so much better than Ordnance... And plasma causes toxin damage anyway so it's not, like, terribly inaccurate.

What if you renamed it to "T0xinz" instead? That'd fix the pathing issue right? Or like "T.oxins"? I dunno man seems weird to change the whole name that's been that way for years because of how it shows up in the cooder programs.
what?
You heard me, green man.

Re: rip toxins

Posted: Mon Aug 02, 2021 7:31 am
by Tlaltecuhtli
orangedance? what a terrible name

Re: rip toxins

Posted: Mon Aug 02, 2021 7:35 am
by TheFinalPotato
sinfulbliss wrote:
TheFinalPotato wrote:
sinfulbliss wrote:Cuban Pete is rolling in his grave. Toxins sounds so much better than Ordnance... And plasma causes toxin damage anyway so it's not, like, terribly inaccurate.

What if you renamed it to "T0xinz" instead? That'd fix the pathing issue right? Or like "T.oxins"? I dunno man seems weird to change the whole name that's been that way for years because of how it shows up in the cooder programs.
what?
You heard me, green man.
excuse me?

Re: rip toxins

Posted: Mon Aug 02, 2021 9:05 am
by sinfulbliss
TheFinalPotato wrote:
sinfulbliss wrote:
TheFinalPotato wrote:
sinfulbliss wrote:Cuban Pete is rolling in his grave. Toxins sounds so much better than Ordnance... And plasma causes toxin damage anyway so it's not, like, terribly inaccurate.

What if you renamed it to "T0xinz" instead? That'd fix the pathing issue right? Or like "T.oxins"? I dunno man seems weird to change the whole name that's been that way for years because of how it shows up in the cooder programs.
what?
You heard me, green man.
excuse me?
I said...

Re: rip toxins

Posted: Mon Aug 02, 2021 10:46 am
by Agux909
EOBGames wrote:What will those crazy coders do next
Genetics= Deviations
Xenobiology= Bio-tampering
Robotics= Borg Assembly

Re: rip toxins

Posted: Mon Aug 02, 2021 1:01 pm
by wet socks
ordnance sounds cooler tho

Re: rip toxins

Posted: Mon Aug 02, 2021 1:50 pm
by cacogen
in a rare moment of self-restraint i opted not to say ordnance sounds off but now i will. i think it needs to refer to the relevant scientific field

Re: rip toxins

Posted: Mon Aug 02, 2021 2:05 pm
by Rohen_Tahir

cacogen wrote:in a rare moment of self-restraint i opted not to say ordnance sounds off but now i will. i think it needs to refer to the relevant scientific field
So physics?

Re: rip toxins

Posted: Mon Aug 02, 2021 3:47 pm
by cacogen
no, something more specific

Re: rip toxins

Posted: Mon Aug 02, 2021 3:57 pm
by wubli
Please I just learned it you can't just remove it
Edit number one Wait I'm really stupid can someone translate the pr to me and me being a 12 year old
Edit number two YOu guys fucking scared me I'm sleep deprived you can't do this to me it's just a re-name I' m going to cry

Re: rip toxins

Posted: Mon Aug 02, 2021 4:20 pm
by Agux909
wubli wrote:Please I just learned it you can't just remove it
Edit number one Wait I'm really stupid can someone translate the pr to me and me being a 12 year old
Edit number two YOu guys fucking scared me I'm sleep deprived you can't do this to me it's just a re-name I' m going to cry
There there. But yeah, what it does is basically this:

All references for the science department are now labeled "Ordnance" instead of "Toxins"
All references for plasma as the gas are now labeled "Plasma" instead of "Toxins"
References for toxin damage are still labeled "Toxins"

So now the code is less of a spaghetti mess when having to rummage through it for toxin references.

Re: rip toxins

Posted: Mon Aug 02, 2021 4:33 pm
by Rohen_Tahir
wubli wrote:Please I just learned it you can't just remove it
Edit number one Wait I'm really stupid can someone translate the pr to me and me being a 12 year old
Edit number two YOu guys fucking scared me I'm sleep deprived you can't do this to me it's just a re-name I' m going to cry
░░░░░▄▄▄▄▀▀▀▀▀▀▀▀▄▄▄▄▄▄░░░░░░░
░░░░░█░░░░▒▒▒▒▒▒▒▒▒▒▒▒░░▀▀▄░░░░
░░░░█░░░▒▒▒▒▒▒░░░░░░░░▒▒▒░░█░░░
░░░█░░░░░░▄██▀▄▄░░░░░▄▄▄░░░░█░░
░▄▀▒▄▄▄▒░█▀▀▀▀▄▄█░░░██▄▄█░░░░█░
█░▒█▒▄░▀▄▄▄▀░░░░░░░░█░░░▒▒▒▒▒░█
█░▒█░█▀▄▄░░░░░█▀░░░░▀▄░░▄▀▀▀▄▒█
░█░▀▄░█▄░█▀▄▄░▀░▀▀░▄▄▀░░░░█░░█░
░░█░░░▀▄▀█▄▄░█▀▀▀▄▄▄▄▀▀█▀██░█░░
░░░█░░░░██░░▀█▄▄▄█▄▄█▄████░█░░░
░░░░█░░░░▀▀▄░█░░░█░█▀██████░█░░
░░░░░▀▄░░░░░▀▀▄▄▄█▄█▄█▄█▄▀░░█░░
░░░░░░░▀▄▄░▒▒▒▒░░░░░░░░░░▒░░░█░
░░░░░░░░░░▀▀▄▄░▒▒▒▒▒▒▒▒▒▒░░░░█░
░░░░░░░░░░░░░░▀▄▄▄▄▄░░░░░░░░█░░

Re: rip toxins

Posted: Mon Aug 02, 2021 4:57 pm
by EOBGames
cacogen wrote:no, something more specific
Perhaps it could refer to the production of explosives- something like Ordnance, maybe?

Re: rip toxins

Posted: Mon Aug 02, 2021 5:04 pm
by MMMiracles
i thought ordnance meant like artillery

Re: rip toxins

Posted: Mon Aug 02, 2021 5:07 pm
by cacogen
no, i was thinking something more in line with genetics or robotics or xenobiology or cytology

Re: rip toxins

Posted: Mon Aug 02, 2021 5:10 pm
by Agux909
MMMiracles wrote:i thought ordnance meant like artillery
Well, what is artillery exactly?

Re: rip toxins

Posted: Mon Aug 02, 2021 5:21 pm
by EOBGames
MMMiracles wrote:i thought ordnance meant like artillery
Technically it's a title for any military explosive, bombs and such would qualify too.
On a serious note, a scientific title for what's done in Toxins would probably be Energetics, but that's a convoluted title that doesn't, in my eyes, roll off the tongue as well as Ordnance.

Re: rip toxins

Posted: Mon Aug 02, 2021 5:28 pm
by Tlaltecuhtli
EOBGames wrote:
MMMiracles wrote:i thought ordnance meant like artillery
Technically it's a title for any military explosive, bombs and such would qualify too.
On a serious note, a scientific title for what's done in Toxins would probably be Energetics, but that's a convoluted title that doesn't, in my eyes, roll off the tongue as well as Ordnance.
well this isnt tg mc , so military explosives arent what they make, toxin should be changed to boomer department as they make shit go boom

Re: rip toxins

Posted: Mon Aug 02, 2021 7:52 pm
by sinfulbliss
EOBGames wrote:
MMMiracles wrote:i thought ordnance meant like artillery
Technically it's a title for any military explosive, bombs and such would qualify too.
On a serious note, a scientific title for what's done in Toxins would probably be Energetics, but that's a convoluted title that doesn't, in my eyes, roll off the tongue as well as Ordnance.
Personally ordnance is a kinda quirky word which doesn’t really roll off the tongue easily cause of the double “dn” consonants. Feels weird to say. Maybe for Brits...
Why not just “Explosives”? I doubt many people know what “ordnance” means offhand.

Re: rip toxins

Posted: Mon Aug 02, 2021 8:17 pm
by Pandarsenic
I'm with the "Boomer Department" thing here

Re: rip toxins

Posted: Mon Aug 02, 2021 9:08 pm
by EuSouAFazenda
Agux909 wrote:
wubli wrote:Please I just learned it you can't just remove it
Edit number one Wait I'm really stupid can someone translate the pr to me and me being a 12 year old
Edit number two YOu guys fucking scared me I'm sleep deprived you can't do this to me it's just a re-name I' m going to cry
There there. But yeah, what it does is basically this:

All references for the science department are now labeled "Ordnance" instead of "Toxins"
All references for plasma as the gas are now labeled "Plasma" instead of "Toxins"
References for toxin damage are still labeled "Toxins"

So now the code is less of a spaghetti mess when having to rummage through it for toxin references.
Someone coded this.

Re: rip toxins

Posted: Mon Aug 02, 2021 10:13 pm
by cocothegogo
my uncle is oranges and he says there gonna remove fun from the game next

Re: rip toxins

Posted: Mon Aug 02, 2021 10:51 pm
by Gigapuddi420
Toxins: SOUL
Ordinance: SOULLESS

Re: rip toxins

Posted: Mon Aug 02, 2021 11:20 pm
by Capsandi
I would be so pissed at the pr renaming the toxins department if 'ordnance' didn't sound 100x cooler

Re: rip toxins

Posted: Tue Aug 03, 2021 12:27 am
by XivilaiAnaxes
This is a stupid complaint who gives a fuck what a niche part of science is labelled as.

It makes it easier on the poor sods that work for free to make the game better. You'll get used to the new nomenclature.

Re: rip toxins

Posted: Tue Aug 03, 2021 2:36 am
by sinfulbliss
XivilaiAnaxes wrote:This is a stupid complaint who gives a fuck what a niche part of science is labelled as.

It makes it easier on the poor sods that work for free to make the game better. You'll get used to the new nomenclature.
You know what, you're right. Coders deserve a break. I therefore propose a new system.
For ease of use, I propose we get rid of the departmental names entirely. We replace them with something simple, so it's most efficient on the backend.
"Genetics" will be "G"
"Xenobiology" will be "X"
Toxins will be "T"
Sec will be "S"
And so forth. This should greatly simplify matters.
(Note: in cases where there are conflicts (i.e., science and sec both "S"), we can use more letters. So "SCI" and "SEC.")

Re: rip toxins

Posted: Tue Aug 03, 2021 2:40 am
by Mothblocks
Use descriptive and obvious names

Optimize for readability, not writability. While it is certainly easier to write M than victim, it will cause issues down the line for other developers to figure out what exactly your code is doing, even if you think the variable's purpose is obvious.
Don't use abbreviations

Avoid variables like C, M, and H. Prefer names like "user", "victim", "weapon", etc.

// What is M? The user? The target?
// What is A? The target? The item?
/proc/use_item(mob/M, atom/A)

// Much better!
/proc/use_item(mob/user, atom/target)

Unless it is otherwise obvious, try to avoid just extending variables like "C" to "carbon"--this is slightly more helpful, but does not describe the context of the use of the variable.

Re: rip toxins

Posted: Tue Aug 03, 2021 2:52 am
by XivilaiAnaxes
sinfulbliss wrote:
XivilaiAnaxes wrote:This is a stupid complaint who gives a fuck what a niche part of science is labelled as.

It makes it easier on the poor sods that work for free to make the game better. You'll get used to the new nomenclature.
You know what, you're right. Coders deserve a break. I therefore propose a new system.
For ease of use, I propose we get rid of the departmental names entirely. We replace them with something simple, so it's most efficient on the backend.
"Genetics" will be "G"
"Xenobiology" will be "X"
Toxins will be "T"
Sec will be "S"
And so forth. This should greatly simplify matters.
(Note: in cases where there are conflicts (i.e., science and sec both "S"), we can use more letters. So "SCI" and "SEC.")
This is stupid and you should feel bad for posting it.

Re: rip toxins

Posted: Tue Aug 03, 2021 4:30 am
by sinfulbliss
Jaredfogle wrote:Use descriptive and obvious names

Optimize for readability, not writability. While it is certainly easier to write M than victim, it will cause issues down the line for other developers to figure out what exactly your code is doing, even if you think the variable's purpose is obvious.
Don't use abbreviations

Avoid variables like C, M, and H. Prefer names like "user", "victim", "weapon", etc.

// What is M? The user? The target?
// What is A? The target? The item?
/proc/use_item(mob/M, atom/A)

// Much better!
/proc/use_item(mob/user, atom/target)

Unless it is otherwise obvious, try to avoid just extending variables like "C" to "carbon"--this is slightly more helpful, but does not describe the context of the use of the variable.
That checks out.

Re: rip toxins

Posted: Tue Aug 03, 2021 6:07 am
by TheFinalPotato
Here's an ss13 alphabet that I not motblocks collected!

Code: Select all

For your entertainment, here's some of the alphabet of SS13, the variable names of real code:

A - Atom, area, admins, augury, advanced disease, arrivals shuttle, asset, award
B - Blob, button, blue, area again (for some reason), blindfold, bomb
C - Carbon, client, simple_animal in create_random_spawn for some reason, count, corner, circuit, cinematic
D - Datum, design, bank account (yes, really), duct, drone
E - Radial entry, explosive, eye, ethereal, edible, emitter
F - Flat, frame, flasher, fire alarm, fire ball, filter, foam
G - Green, ghost, guardian, gloves, goal, high five (again, for seemingly no reason), gang
H - Human, holder, hunter, item (as both h and H in drag_drop.dm), holopad
I - Item, icon, interview, organ, implant, ID, image, immobilized
J - Icon again, job, jaunt, jetpack, cult spell (for seemingly no reason)
K - Keycard, knockdown, kinetic blast, knife
L - List, living, lighting, laws, limb, lungs, loot, turf
M - Mob, month, matrix, mode, machine, message, mobile
N - Nuke, new player, new, area for some reason in weather.dm, nozzle, node
O - Object, observer, objective, robot (for some reason), closet, outfit, body parts
P - Client, paper, node, pack, plumbing, point, player details, projectile
Q - Turf, carbon, query, quirk, reagents
R - Regex, ref, robot, mech, radio, role
S - Silicon, swarmer, shuttle, shelter, start, symptom
T - Turf, techweb, quirk, tackle, temperature, cyborg gun
U - Under, uplink, user, turf, upgrade
V - Vote, vomit, rods, mask, vampire
W - Weakref, weather, item, wound, particle, wall
X - Xenobio, extract, golem, paper
Y - We don't seem to have used Y as a variable name for anything other than y coordinates. Hooray!
Z - Plasma tank, drone, victim
Aren't I clever?

Re: rip toxins

Posted: Tue Aug 03, 2021 6:07 am
by Yenwodyah
You couldn't possibly make up a more soulless name than "Ordnance".

Re: rip toxins

Posted: Tue Aug 03, 2021 9:08 am
by Mothblocks
what's next engineering?

Re: rip toxins

Posted: Tue Aug 03, 2021 9:49 am
by Super Aggro Crag
Fucking science boomers and their ancient spaghetty department that literally existed only to blow holes in the station