Page 1 of 1

Robustin appreciation topic.

Posted: Wed Mar 28, 2018 7:03 pm
by Bluespace
https://github.com/tgstation/tgstation/pull/36781
https://github.com/tgstation/tgstation/pull/36776
https://github.com/tgstation/tgstation/pull/36762
https://github.com/tgstation/tgstation/pull/36756
https://github.com/tgstation/tgstation/pull/36650
https://github.com/tgstation/tgstation/pull/36667
https://github.com/tgstation/tgstation/pull/36662
https://github.com/tgstation/tgstation/pull/36641

Whilst Robustin hasn't got the best reputation as a coder, we can't deny that what he's doing here is fantastic in every way. This is a thread in which you can let him know you're watching him working that code like bread dough.
He's even optimising atmos code, the madman. :heart:

Re: Robustin appreciation topic.

Posted: Wed Mar 28, 2018 7:10 pm
by LifeReign
But where am I supposed to get my 100% FREE LAG now? That stuff doesn't grow on trees!

Re: Robustin appreciation topic.

Posted: Wed Mar 28, 2018 7:58 pm
by DemonFiren
wtf i love robustin now

Re: Robustin appreciation topic.

Posted: Wed Mar 28, 2018 9:41 pm
by Saegrimr
That's pretty impressive, nice work.

Re: Robustin appreciation topic.

Posted: Wed Mar 28, 2018 9:52 pm
by Nabski
Imagine how many more he would have if he atomized his PRs!

Re: Robustin appreciation topic.

Posted: Wed Mar 28, 2018 10:02 pm
by Oldman Robustin
Aww shucks.

I'm working on overlays now, which are the real performance killer when the servers get busy, but its even more of a headache than atmos - which at least tried to follow predictable rules.

Keep in mind I am not a coder by education or profession, so its really nice to get positive feedback like this after trying to figure out even basic code for years.

Re: Robustin appreciation topic.

Posted: Thu Mar 29, 2018 5:36 am
by SpaceManiac
Oldman Robustin wrote:I am not a coder by education or profession,
This can actually be an advantage in certain situations.

Great work.

Re: Robustin appreciation topic.

Posted: Thu Mar 29, 2018 8:16 am
by Not-Dorsidarf
Oldman Robustin wrote:Aww shucks.

I'm working on overlays now, which are the real performance killer when the servers get busy, but its even more of a headache than atmos - which at least tried to follow predictable rules.

Keep in mind I am not a coder by education or profession, so its really nice to get positive feedback like this after trying to figure out even basic code for years.
You do have an admirable ability to think around a problem with the code though

Re: Robustin appreciation topic.

Posted: Thu Mar 29, 2018 11:24 am
by Lumbermancer
Unused cycles are wasted cycles. Give me my money back.

Re: Robustin appreciation topic.

Posted: Thu Mar 29, 2018 12:30 pm
by Selea
Robustin gone incredibly robust and started coding spree.

Re: Robustin appreciation topic.

Posted: Thu Mar 29, 2018 12:44 pm
by SpaceInaba
he's good when he isn't messing with balance

Re: Robustin appreciation topic.

Posted: Thu Mar 29, 2018 1:22 pm
by Selea
Tbh, good balance is incredibly hard thing to do.
Especially if there aren't design document, which declares, which things are appreciated or not.

Re: Robustin appreciation topic.

Posted: Thu Mar 29, 2018 1:54 pm
by D&B
Ganbatte Robustin

Re: Robustin appreciation topic.

Posted: Thu Mar 29, 2018 3:44 pm
by Armhulen
Our guy

Re: Robustin appreciation topic.

Posted: Thu Mar 29, 2018 7:25 pm
by Deitus
Robustin is unironically the hero we need but don't deserve tbqh

Re: Robustin appreciation topic.

Posted: Fri Mar 30, 2018 10:37 am
by Not-Dorsidarf
a good guy whos always willing to give a dead monkey a second chance

Re: Robustin appreciation topic.

Posted: Fri Mar 30, 2018 10:57 am
by bandit
damn

everyone has potential

*wipes tear from eye*

Re: Robustin appreciation topic.

Posted: Fri Mar 30, 2018 11:09 pm
by Oldman Robustin
I-Ive done it.

I cracked overlay code.

The results of my improvement are... indescribable. Overlays, human overlays especially, were by far the greatest source of lag known to our servers. They completely overshadowed even atmos for processing consumption on Midpop+ servers.

I picked up and put down a PDA in the dorms ~125 times (one overlay update for dropping, one for picking up) and gave the code a 50% chance to use our current method and a 50% chance to use my test method:

Current Overlay Code => 1120ms (133) (avg:8.4210529327392578)

Robustin Code => 6ms (112) (avg:0.0535714291036129)

My code wasn't some exotic change, 99% of it is identical to how we do it now (which also has room for improvement), but all I did was change a couple operators at the heart of the code and its magical.

Re: Robustin appreciation topic.

Posted: Sat Mar 31, 2018 1:50 am
by Dr_bee
While I often badmouth Robustin for some of his balance decisions, I have to say that seeing him work on speeding up how the game processes things to remove the FREE LAG is something I enjoy seeing.

Keep up the good work so far man, looks good.

Re: Robustin appreciation topic.

Posted: Sat Mar 31, 2018 1:59 am
by Selea
No, really. There are far less lag now. Thank you.

Re: Robustin appreciation topic.

Posted: Sat Mar 31, 2018 2:46 am
by ThanatosRa
Holy crap dude.

Re: Robustin appreciation topic.

Posted: Sat Mar 31, 2018 11:06 am
by Bluespace
Put a Robustin statue in game.

Re: Robustin appreciation topic.

Posted: Sat Mar 31, 2018 11:15 am
by Saegrimr
Bluespace wrote:Put a Robustin statue in game.
Only if its a holographic overlay powered by reacting gasses in pipes underneath it.

Re: Robustin appreciation topic.

Posted: Sat Mar 31, 2018 3:05 pm
by Cobby
Balance Bad,

Improvements Good.