Page 8 of 8
Re: Umbrage: Shadowling Redux (Now on GitHub!)
Posted: Sat Mar 11, 2017 5:12 am
by oranges
Bottom post of the previous page:
right, it's still everyone elses fault and not your own, the only person standing in the way of the finishing of your mode is you with your refusal to remove the conversion aspect.
You only had to make one change and you still wont' do it. Instead you'll just blame everyone else.
You're invested because it's your code. I review 52+ pr's a month, I don't have time to form an attachement to every single one.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 5:17 am
by ShadowDimentio
You're both wrong. Kor is wrong for having a vendetta against conversion modes, Xhuis my dude you're wrong for refusing to capitulate for Kor's admittedly stupid demand.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 5:19 am
by Xhuis
I know that it was my fault. I said myself that I fully accept that it was my own choice not to agree to the demand and I wanted to have some time to think it over as it had been made apparently clear that I had two days to do it. I was presenting arguments to see if I could sway him in the time that I had and, while I do not hold myself responsible for the instant, premature closing, I do for my own complaints and refusal to comply. I thought that I had had time to debate but it seems that I was wrong.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 5:21 am
by oranges
Closing a pr doesn't mean you can't keep debating it or bring it back later, maybe I was hasty in closing it but from my position it looked like a lot of people just abusing someone with a shitty job to do.
You're the one who seems to think I have brought your entire world to an end with a single action.
All you and Kor have to do is find some quiet time alone in pm's and sort something out, but why would they want to now after all this abuse they got.
Re: Umbrage: Shadowling Redux (Now on GitHub!)
Posted: Sat Mar 11, 2017 5:22 am
by Armhulen
"48 Hours to remove conversion"
Closed within an hour
ShadowDimentio if he knew oranges would kill his project in an hour he wouldn't have considered otherwise
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 5:24 am
by oranges
Yeah because we all know I'm apparently the last word on everything, it's not like I have been overruled before because I have a shadow hand controlling everyone else that prevents anyone from telling me what to do.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 5:25 am
by Xhuis
Every time a maintainer has closed one of my pull requests it has never been opened again. It is usually a death sentence for the pr and I know that unless you actively take steps to reopen it that this will be the same. Knowing how people feel about it among the higherups has killed my motivation at any rate, and I would rather let the mode die with what was there as good then finish it as a bad gamemode.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 5:27 am
by Armhulen
Man this shit sucks, at least let the poor man have a testmerge with or without it. Xhuis is right in that this killed his PR. Nobody is going to reopen it so Xhuis can do what the design lead asks and you know it
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 5:29 am
by oranges
if he removed conversion I'd reopen it immediately assuming that was the primary reason kor was planning to close it.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 5:30 am
by Xhuis
Thank you for the sympathy but the gamemode is not in a state where it can be testmerged. There is not even a win condition implemented yet. As I said I do not want to continue on it but it might change later in the weekend. I will keep the code on my local branch in case I decide to continue.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 5:37 am
by Armhulen
Please continue working on it. I'm a huge fan of what you made, the Being was fun reading the document every other day for new changes, Shadowling was extremely fun to play and Revenant is my second favorite sideantag.
You can still make Umbrage good, without conversion. Even though you never announced it, Listening bug is extremely cool.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 5:49 am
by Haevacht
[quote=Xhuis]I know you are probably rolling your eyes[/quote]
You know me very, very well.
You're great at desperate grabs for sympathy. Come back tomorrow and make it not convert. It'll get reopened, probably merged.
It's not fucking over until you delete it.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 5:56 am
by Xhuis
I already did delete it, Haevacht. What do I have to gain by grabbing sympathy? People who like the mode have already liked it and people who do not will not. I am, speaking truthfully and from my heart, very distressed that umbrage is, in fact, kill, and I for the time being have lost motivation to work on it, but it may return later.
In the meantime, please do not make assumptions about me. I never attempt to garner sympathy from people, at least not consciously. I do not like manipulating people.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 5:59 am
by Haevacht
Xhuis wrote:I already did delete it, Haevacht. What do I have to gain by grabbing sympathy? People who like the mode have already liked it and people who do not will not. I am, speaking truthfully and from my heart, very distressed that umbrage is, in fact, kill, and I for the time being have lost motivation to work on it, but it may return later.
In the meantime, please do not make assumptions about me. I never attempt to garner sympathy from people, at least not consciously. I do not like manipulating people.
Then game over.
And you don't have to do something intentionally to be good at it. I'm pretty good at breathing, myself.
Always next time, whenever that may be.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 6:14 am
by Cheridan
branches can be un-deleted and all the code changes are still on the pr
just saying.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 6:17 am
by Xhuis
I know, don't worry. I may be overly dramatic but I still can into github. As I've mentioned though my enjoyment of the project is currently facedown in the shallow pool of our game's depth (get it because of the thread going on right now haha) but everything is subject to change. Although my long writeup is quite dramatic in saying that I failed everyone and would not bring it back, the chances are that in a few weeks I may revive it when I am feeling up to it again. Writing when you are very strongly emotional tends to make one blow things out of proportion.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 11:10 am
by Bluespace
I wonder what direction the design lead(s) intend for tgstation to take tbh.
Can we expect the removal of both cults and rev?
Every round a toss up between traitor and ling?
SS13 becoming "do your job until a traitor kills you?"
I am a mere player, when the design lead cums in my mouth I either swallow or put my heels on and leave.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 11:49 am
by Steelpoint
If one maintainer says you have 48 hours to effect a change before they will close it, that essentially states for fact that you have 48 hours to either make your case or make the requested change.
oranges closing the PR barely a hour after the proclamation is not only a poor PR move, but it shows a lack of professionalism or integrity.
On principle the PR would be reopenend and given 47 hours to effect the demanded changes.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 12:07 pm
by Armhulen
Steelpoint wrote:If one maintainer says you have 48 hours to effect a change before they will close it, that essentially states for fact that you have 48 hours to either make your case or make the requested change.
oranges closing the PR barely a hour after the proclamation is not only a poor PR move, but it shows a lack of professionalism or integrity.
On principle the PR would be reopenend and given 47 hours to effect the demanded changes.
This above all else
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 12:43 pm
by TrustyGun
Yeah, even ignoring the rest of the drama, closing the PR without giving the chance for Xhuis to work on it is really fucking shitty. Especially considering that Kor told him he had 48 hours to do that 2 hours prior. Even moreso that Orange's reason was "lol".
Open the PR back up, give him another 48 hours.
Re: Umbrage: Shadowling Redux (canceled)
Posted: Sat Mar 11, 2017 3:23 pm
by Xhuis
Follow-up post the day after now that the dust has cleared. List of stuff in no real order:
- I'm no longer immensely frustrated over the whole ordeal and I can think on things more.
- I respect Kor's decision to give me an ultimatum, although I don't like it. With oranges giving his reasoning I can see from his perspective but I do not respect it. Closing PRs because I have a disagreement with the design lead - who has a higher position than you and said that I had time to think and work on it - is not the right thing to do.
- I have less motivation to work on this but it's still there. Just not right now. I will probably wait for a while before I continue but the code and assets remain in case I want to continue at some point.
- Although maintainers have extended an olive branch and offered to open the PR again, for now I will let it stay closed. I do not want to cause more drama by pushing commits that go against what they requested. When I am ready to work on it again I will request its reopening or make another PR.
- Because of how distressed I was last night, my write-ups and general attitude was extremely dramatic. I said a lot of things that weren't true and sounded nothing but petulant. I was pretty whiny but I think that my jabs were justified at the time and I don't regret saying them. I still dislike oranges for sucking up to Kor and taking matters into his own hands when the situation wasn't as bad as it was, and I still dislike Kor for valuing his own opinion above everyone else's (yes, even as the design lead. He hasn't done much in that position. The only post about direction came up after the whole drama with oranges' post.)
Can't think of anything else at the moment. If you have any questions I'm all ears, but I can't stick around for long.
Re: Umbrage: Shadowling Redux (delayed?)
Posted: Mon Apr 03, 2017 3:11 am
by danno
11 paragraphs in one post alone
jesus
Re: Umbrage: Shadowling Redux (delayed?)
Posted: Mon Apr 03, 2017 3:31 am
by Armhulen
danno wrote:11 paragraphs in one post alone
jesus
reviving this sad ass thread
feels p bad man
Re: Umbrage: Shadowling Redux (delayed?)
Posted: Mon Apr 03, 2017 3:34 am
by onleavedontatme
Reminder I'd still merge shadowling if it had no conversion in it.
Re: Umbrage: Shadowling Redux (delayed?)
Posted: Mon Apr 03, 2017 3:34 am
by Armhulen
Most active topic:Umbrage: Shadowling Redux (delayed?)
i'd be ready to remove conversion and add this already
Re: Umbrage: Shadowling Redux (delayed?)
Posted: Mon Apr 03, 2017 4:45 am
by ShadowDimentio
Kor wrote:Reminder I'd still merge shadowling if it had no conversion in it.
Reminder you're a rude dude
Re: Umbrage: Shadowling Redux (delayed?)
Posted: Mon Apr 03, 2017 5:29 am
by oranges
ShadowDimentio wrote:Kor wrote:Reminder I'd still merge shadowling if it had no conversion in it.
Reminder you're a rude dude
That's rich david
Re: Umbrage: Shadowling Redux (delayed?)
Posted: Mon Apr 03, 2017 4:15 pm
by onleavedontatme
Armhulen wrote:Most active topic:Umbrage: Shadowling Redux (delayed?)
i'd be ready to remove conversion and add this already
You are free to do so, the code is there for anyone to edit and finish.
Re: Umbrage: Shadowling Redux (delayed?)
Posted: Tue Apr 04, 2017 6:18 pm
by Xhuis
Eh? Who hath awak'd me from my slumber?
Anyway yeah. I know that this is fine without conversion, and I'll probably continue it when I get the motivation. Right now, however, I am in a turbulent time (moving to another state) and I also have little motivation to continue it. The code is open for anyone who wants to work on it, but until then, just wait until I can pick it up.