PKPenguin321 wrote:Why not let on more maintainers instead of handling 99% of the PRs by yourself, oranges?
This implies I have a choice in how many pr's I handle.
To me it seems like I wait for someone else to merge it and then the pr is open for many days, no action, I wait and I wait and then at some point I lose patience with waiting and just handle the pr
It's not your onus to keep the pr list short, do what your comfortable doing and if it turns out that the PR page isn't being handled by other people THEN have a discussion about needing more help. Ultimately if one person seems willing to preemptively take on extra "work" most people aren't gonna say "no, don't make my life easier!".
Because it's a bad faith and rude to people who put their work on our tracker. We owe them a reasonably timely review and I feel embarrassed whenever items stay there for a long item with no activity on our part. It feels like a failure to me.
PKPenguin321 wrote:Why not let on more maintainers instead of handling 99% of the PRs by yourself, oranges?
This implies I have a choice in how many pr's I handle.
To me it seems like I wait for someone else to merge it and then the pr is open for many days, no action, I wait and I wait and then at some point I lose patience with waiting and just handle the pr
It's not your onus to keep the pr list short, do what your comfortable doing and if it turns out that the PR page isn't being handled by other people THEN have a discussion about needing more help. Ultimately if one person seems willing to preemptively take on extra "work" most people aren't gonna say "no, don't make my life easier!".
Because it's a bad faith and rude to people who put their work on our tracker. We owe them a reasonably timely review and I feel embarrassed whenever items stay there for a long item with no activity on our part. It feels like a failure to me.
Counterpoint: No we don't?
This is a volunteer driven open source project with no money involved where the grand majority of developers are at a hobbyist level or lower, No one's entitled to anything here.
Don't beat yourself up over it, we do what we can with the time we're willing to invest into the things we find fun and/or interesting. That's all any of this is.
You hurt the project when you dick around with someone else's personal time. That causes people to leave and get angry. At that point it would literally be better to just automerge things and not have a review process at all since it would do more harm than good.
I code for the code project and moderate the code sections of the forums.
honestly, the best solution is to just encourage people to self-close their wip things if it ends up taking more time before its ready so they can self-open them once its ready.
When you add the stale tag, specify "I'm going to close this in so and so hours if it has no substantial commit activity, you are encouraged to close it yourself before then so that you can open it yourself when it is ready" or some other shit.
Forum/Wiki Administrator, Server host, Database King, Master Coder
MrStonedOne(!vAKvpFcksg) on Reddit(banned), Steam, IRC, Skype Discord. Don't click this
After this pitiful freeze (1000 -> 927 issues even while pruning old, non-issues) I'm going to see about implementing something for this into tgstation-server with a configurable rate limit. We have tons of bugs but no motivation to fix them. Hopefully this gives regular coders the kick in the ass they need in order to do so.
iamgoofball wrote:
oranges wrote:That adds a lot of bookkeeping overhead MrStonedOne
Besides the only people who can really delay a PR are maintainers
yes but maintainers don't want to take the fall for a PR that seems unpopular because 3 people spammed 200 comments
The only opinions I adhere to are maintainers, headmins, atlanta, and MSO. If I'm not merging it, it either A) sucks in my eye B) failed code review C) failed travis D) looks to complex/big/unknown for me to review it atm. Also the bookkeeping is easy with an automatic database.
Last edited by Cyberboss on Mon Aug 14, 2017 7:04 pm, edited 1 time in total.
kevinz000 wrote:personally i'd hate this because i make shitcode and shitfeatures and have like 3 stale memes open
but in the end this would be a good change to make that stuff not happen :^)
Ohhh mmmyyyyyyy whaaaaateeeevvveeerrr willl we dooooo
Real talk, irritating but agreeable, but i would like there to be some room to negotiate however on additional PR's if there is a good enough reason or its related to the first in a directly conjoined way. Get permission in IRC coderbus?
